Custom List Fields Feature has been committed to SVN trunk!

Discussions about development of VICIDIAL and astGUIclient

Moderators: gerski, enjay, williamconley, Op3r, Staydog, gardo, mflorell, MJCoate, mcargile, Kumba, Michael_N

Postby williamconley » Wed Dec 15, 2010 7:38 pm

best practices suggests having a specific user ONLY have the ability to perform this task (not any user created by default has this capability, that could be disastrous in ways similar to allowing passengers in your car all control the accelerator! :))

so having that in the documentation (when complete) will certainly be necessary, but having it automatically enabled would be dangerous
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

Postby dspaan » Wed Dec 15, 2010 8:18 pm

Agreed. I also found a small bug. If you use quotes 'like this' in the Field Help it does not commit the changes/add the field.
dspaan
 
Posts: 1374
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Postby williamconley » Thu Dec 16, 2010 12:36 am

yep, that happens a lot. post it in the VICIDIAL Issue Tracker (be specific) and it'll get fixed :) (Contribute! Find the flaw and post the diff file that fixes it! :))
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

Postby dspaan » Thu Dec 16, 2010 6:13 am

Thanks. I submitted it to the issuetracker. Would not know where to begin to make a diff file. My experience with programming is zero.
dspaan
 
Posts: 1374
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Postby dspaan » Thu Dec 16, 2010 9:25 am

I can't seem to get the custom fields to show up in my campaign.

I added the custom fields to a list that was already active on a campaign.
The list is active.
In the campaign settings i have set 'Get call launch' to FORM.
I have also enabled a script (so i would expect a script and a form tab).

Please help.
Regards, Dennis

Vicibox 9.0.1
Version: 2.14b0.5
SVN Version: 3199
DB Schema Version: 1588
Build: 200310-1801
dspaan
 
Posts: 1374
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Postby mflorell » Thu Dec 16, 2010 9:27 am

Manual dial call?
mflorell
Site Admin
 
Posts: 18335
Joined: Wed Jun 07, 2006 2:45 pm
Location: Florida

Postby dspaan » Thu Dec 16, 2010 9:30 am

Yes i was testing with manual, i can't see the fields then?
Regards, Dennis

Vicibox 9.0.1
Version: 2.14b0.5
SVN Version: 3199
DB Schema Version: 1588
Build: 200310-1801
dspaan
 
Posts: 1374
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Postby mflorell » Thu Dec 16, 2010 9:35 am

What is your manual dial list ID set to in your campaign?
mflorell
Site Admin
 
Posts: 18335
Joined: Wed Jun 07, 2006 2:45 pm
Location: Florida

Postby dspaan » Thu Dec 16, 2010 9:51 am

It was set to 998 while the list i added the fields to was 123. So i changed that but when i logged in as agent i still didn't get to see the custom fields form tab.

edit: i tried predictive dialing but i still can't see the form tab
Regards, Dennis

Vicibox 9.0.1
Version: 2.14b0.5
SVN Version: 3199
DB Schema Version: 1588
Build: 200310-1801
dspaan
 
Posts: 1374
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Postby williamconley » Thu Dec 16, 2010 4:59 pm

does your user have custom fields set to 1?
also assign a script to this campaign (some versions have this bug)
did you change your campaign to pop up the form when the agent gets a call? (not the web form, the Form)

did you make a call to see if it worked? or just log in?

thank you for posting all your specs!!!
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

Postby dspaan » Thu Dec 16, 2010 6:10 pm

Yes, i set that field to 1. I didn't think i had to set it to 1 for the agent as well since it's listed under admin options but i did it anyway.

I did assign a script to this campaign and set it to FORM like in the instruction. Look here:

Image

Uploaded with ImageShack.us

After that i logged in and made some actual calls. I tried manual dialing and adapt_tapered dialing. I only see the script tab and not the form tab.

Just now i even made a new campagin with a new list with just one custom field and a new script and still i don't see that tab when i make some calls. Could it be because i used the old lead loader because of the 3rd generation one? I've sent you a PM William, check it out please. Thanks so far for all the help.
Regards, Dennis

Vicibox 9.0.1
Version: 2.14b0.5
SVN Version: 3199
DB Schema Version: 1588
Build: 200310-1801
dspaan
 
Posts: 1374
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Postby williamconley » Thu Dec 16, 2010 6:19 pm

Sorry, I only do PMs/IMs/Calls for paying clients.

http://www.vicidial.org/vicidial_demo/a ... custom.htm

http://www.vicidial.org/VICIDIALforum/v ... 6087#56087

This is where we got our start on it ... and it seems to work.
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

Postby dspaan » Thu Dec 16, 2010 6:51 pm

I don't think it has anything to do with the form setup. I tried a form that has just one simple field in it and i have the same problem. I did everything according to the instructions. Damn, i really need these custom fields...
Regards, Dennis

Vicibox 9.0.1
Version: 2.14b0.5
SVN Version: 3199
DB Schema Version: 1588
Build: 200310-1801
dspaan
 
Posts: 1374
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Postby dspaan » Tue Dec 21, 2010 7:19 am

Update: I forgot i made one modification after the install: we installed a Dutch language file for the agent interface. After reverting back to English the custom fields form showed up fine. Thanks for the help William.
Regards, Dennis

Vicibox 9.0.1
Version: 2.14b0.5
SVN Version: 3199
DB Schema Version: 1588
Build: 200310-1801
dspaan
 
Posts: 1374
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Postby mflorell » Tue Dec 21, 2010 7:54 am

As a note, it has been mentioned several times before, the multi-language builds are only built when a release comes out, or when specifically noted in svn/trunk. The build_translation_www_files.pl script is capable of making the translation build if you want to update them yourself.
mflorell
Site Admin
 
Posts: 18335
Joined: Wed Jun 07, 2006 2:45 pm
Location: Florida

Postby Disaster » Sun Dec 26, 2010 8:16 pm

mflorell wrote:cd /usr/src/astguiclient/trunk
svn update
perl install.pl

read the UPGRADE doc to see what has changed since your current version

And make sure you run the upgrade on the database!

Then kill all of the screen sessions(don't do this while you are in production of course)

Start Asterisk back up with the start_asterisk_boot.pl script

Then you should be good to go.


I have tried this but have made a mistake somewhere. As everything is exactly the same after upgrade.

I am unsure on how to run the upgrade on the database can someone please advise on this?

Or steps I may be missing?

Current version

VERSION: 2.4-293
BUILD: 101216-1838
Asterisk 1.4.27.1-vici
Dell Poweredge T110.
Disaster
 
Posts: 9
Joined: Tue Oct 12, 2010 4:46 pm

Postby williamconley » Sun Dec 26, 2010 8:39 pm

1) Use the Vicidial Wiki link at the top of the page and use the SVN how to

2) Use the UPGRADE.txt document in /usr/src/astguiclient/trunk

Both contain valuable information

Also please remember to list your installer version when you post (often this can help us to understand your problem and modify directions for distro specific file locations). If not sure, it is likely that the installer version will be listed in the splash screen for your ssh or console login on the vicidial server.

Oh! And thanks for listing your vicidial version with build! That's the single most important item you can list.
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

custom fields not showing in export call reports

Postby striker » Sun Dec 26, 2010 10:26 pm

hi

vicibox_redux 3.0.6|VERSION: 2.4-285|BUILD: 101022-1427 |two port Digium E1 card| no extrasoftware| single server.

I have enabled the custom fields and its working fine . the only problem is

while exporting the call reports i am not getting the headers of the custom fields. only its showing "named as customfields" after rank header.

i have selected header=yes custome fields =yes .
but if i download the list its showing all the custom fields headers.

am i missing any configuration ?
www.striker24x7.com www.youtube.com/c/striker24x7 Telegram/skype id : striker24x7
striker
 
Posts: 962
Joined: Sun Jun 06, 2010 10:25 am

Postby williamconley » Sun Dec 26, 2010 10:35 pm

Um ... language? (IE: have you changed the language of the system at all?)

also: Please specify EXACTLY how you "export the call reports" (url, link, step by step)
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

custom fields not showing in export call reports

Postby striker » Sun Dec 26, 2010 10:41 pm

Hi

i didnt changed any language , the language is in english by default once vicibox_redux installed.

steps to download reports

vicidial administration window--> reports --> export call report

date --selected
headers --> yes
recordings --> all
custom fields--> yes

select campaign ---> test , inbound group--> none , list id-->100, status-->all ,usergroup --> agent or all
then pressed submit
www.striker24x7.com www.youtube.com/c/striker24x7 Telegram/skype id : striker24x7
striker
 
Posts: 962
Joined: Sun Jun 06, 2010 10:25 am

Postby williamconley » Sun Dec 26, 2010 11:56 pm

can you also post the actual headers you got in the download?
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

Postby Disaster » Mon Dec 27, 2010 1:58 am

Ok I had everything right the problem was I had to go to Admin - System Setting - Enable Custom List Fields and set it to (1)
Disaster
 
Posts: 9
Joined: Tue Oct 12, 2010 4:46 pm

custom fields not showing in export call reports

Postby striker » Mon Dec 27, 2010 2:12 am

hi william

check the below link for the headers which i got in the report downloaded

Image
www.striker24x7.com www.youtube.com/c/striker24x7 Telegram/skype id : striker24x7
striker
 
Posts: 962
Joined: Sun Jun 06, 2010 10:25 am

Postby dspaan » Mon Dec 27, 2010 6:05 am

I have this exact same problem. It only shows a 'custom_fields' column which did contain the information of that one custom field i made.
Regards, Dennis

Vicibox 9.0.1
Version: 2.14b0.5
SVN Version: 3199
DB Schema Version: 1588
Build: 200310-1801
dspaan
 
Posts: 1374
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Postby mflorell » Mon Dec 27, 2010 11:56 am

This has been answered several times, the issue is that custom fields are list-based, so you cannot guarantee that the fields will be the same when you download calls, so we cannot list them as field headers. If you want the custom field headers then you need to download the entire list from the list modification page.
mflorell
Site Admin
 
Posts: 18335
Joined: Wed Jun 07, 2006 2:45 pm
Location: Florida

Postby dspaan » Mon Dec 27, 2010 1:04 pm

Do you mean that if you select 'Lists: ALL' you cannot guarantee the fields will be the same?

If yes, then why isn't it possible to export the custom headers if i select a specific list when exporting the calls.

Downloading the list would be an option for me if it contained 'length_in_sec' but it doesn't

:(
Regards, Dennis

Vicibox 9.0.1
Version: 2.14b0.5
SVN Version: 3199
DB Schema Version: 1588
Build: 200310-1801
dspaan
 
Posts: 1374
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Postby williamconley » Mon Dec 27, 2010 1:29 pm

dspaan wrote:Do you mean that if you select 'Lists: ALL' you cannot guarantee the fields will be the same?

If yes, then why isn't it possible to export the custom headers if i select a specific list when exporting the calls.

Downloading the list would be an option for me if it contained 'length_in_sec' but it doesn't

:(
If someone paid for it ... it would be there. The Vicidial Group is the ONLY company capable of guaranteeing that such development will end up IN the code for the next release. And when someone pays them to be sure it's there ... it is.

We (or any one of several others like us, or YOU for that matter) can modify the code to "make it happen" ... but for it to happen for free for the community it has to get done and then submitted to the Vicidial Group for free distribution.

Are you volunteering to pay for this update :)?
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

Postby dspaan » Mon Dec 27, 2010 1:32 pm

Let me first get an overview of the features i'm missing and then i will decide for which one i will make a donation. So far i think ViciDial is awesome! :D
Regards, Dennis

Vicibox 9.0.1
Version: 2.14b0.5
SVN Version: 3199
DB Schema Version: 1588
Build: 200310-1801
dspaan
 
Posts: 1374
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Postby williamconley » Mon Dec 27, 2010 1:46 pm

And not only awesome: STILL the ONLY game in town. (OK: The ONLY Open Source Functional Dialer)
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

Postby DarknessBBB » Wed Jan 05, 2011 11:52 am

Guys, this feature is wonderful!
Only one little issue: if I choose DISPLAY field type, in the agent screen the data doesn't show at all, only the label :(

Image

Uploaded with ImageShack.us
Image

Uploaded with ImageShack.us

ViciBox 3.1.2
Version: 2.4-10 Build: 101228-2049
Single Server
No phone hardware
DarknessBBB
 
Posts: 328
Joined: Mon Jul 16, 2007 10:14 am

Postby williamconley » Wed Jan 05, 2011 12:41 pm

and you're saying this same field will display and allow editing if you do it the other way? (but if you change to display it breaks?)
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

Postby DarknessBBB » Wed Jan 05, 2011 12:51 pm

williamconley wrote:and you're saying this same field will display and allow editing if you do it the other way? (but if you change to display it breaks?)


Yep, no problem for me to use text instead of display for the other values, but the phone number is a very critical data.
DarknessBBB
 
Posts: 328
Joined: Mon Jul 16, 2007 10:14 am

Postby williamconley » Wed Jan 05, 2011 1:52 pm

but to be clear, and not talk about "other values", you are saying that if you JUST change this to Text, this field works fine, but if you change it to Display (the ONLY change), it is broken?
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

Postby DarknessBBB » Wed Jan 05, 2011 2:17 pm

yes :)
DarknessBBB
 
Posts: 328
Joined: Mon Jul 16, 2007 10:14 am

Postby williamconley » Wed Jan 05, 2011 2:43 pm

so dig into the php and find it :)

and / or post it in the issue tracker as a bug. (with specific detail on how to cause it)

i'd probably recommend testing it with a few more fields first (this is a built-in field ... does the same thing happen with a custom field? what about a date field? do some work and others not? or ALL display functions are down?)
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

Postby mflorell » Wed Jan 05, 2011 4:57 pm

I believe this is a known issue, probably related to this one:

http://www.eflo.net/VICIDIALmantis/view.php?id=419

Haven't had a chance to work on it because none of our clients have complained about it, and don't have much free time at the moment.
mflorell
Site Admin
 
Posts: 18335
Joined: Wed Jun 07, 2006 2:45 pm
Location: Florida

Postby DarknessBBB » Fri Jan 07, 2011 5:35 am

williamconley wrote:so dig into the php and find it :)

and / or post it in the issue tracker as a bug. (with specific detail on how to cause it)

i'd probably recommend testing it with a few more fields first (this is a built-in field ... does the same thing happen with a custom field? what about a date field? do some work and others not? or ALL display functions are down?)


Here we go
http://www.vicidial.org/VICIDIALmantis/view.php?id=434

as you can see it was very simple to solve :)
Code: Select all
240c240,241
<                $field_HTML .= "$A_field_default[$o]\n";
---
>                if (strlen($A_field_value[$o]) < 1) {$A_field_value[$o] = $A_field_default[$o];}
>                $field_HTML .= "$A_field_value[$o]\n";
DarknessBBB
 
Posts: 328
Joined: Mon Jul 16, 2007 10:14 am

Postby williamconley » Fri Jan 07, 2011 9:05 am

ooooOOOOOoooo

Very well done :)
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

Postby DarknessBBB » Fri Jan 07, 2011 9:39 am

Mmmm, I see another issue :(
With date fields, if the agent uses the format dd/mm/yyyy or dd-mm-yyyy the field is populated with 0000-00-00
DarknessBBB
 
Posts: 328
Joined: Mon Jul 16, 2007 10:14 am

Postby williamconley » Fri Jan 07, 2011 9:47 am

What documentation are you using? I'm pretty sure that was in ours ... (2nd line, LOL)
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20018
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

PreviousNext

Return to Development

Who is online

Users browsing this forum: No registered users and 27 guests